Introduction
Complete list of issues and enhancements addressed in this release
This is the complete list of issues addressed in Orbeon Forms 3.9.
Fixes between Orbeon Forms 3.9 RC 1 and 3.9 final:
Fixes between version 3.8 and 3.9 RC 1: -
#313231: RFE: Support HTML in checkboxes/radio button item/itemset labels
-
#315894: fr:currency: JavaScript error on Chrome
-
#315707: RFE: oxf:url-generator should support configuration for parsing external entities
-
#315406: Noscript: ATM example fails to resolve "." in submissions
-
#315881: fr:dialog-select: label not showing up anymore
-
#315889: fr:us-phone control: blanking instance data does not blank fields
-
#315440: Changing the oxf.xforms.xpath-analysis property is not taken into account when reloading the form
-
#315865: XBL: "Missing id on XBL binding" error when no id is provided on xbl:binding
-
#315839: Changing oxf.xforms.xhtml-layout has no effect until Tomcat is restarted
-
#315886: Regression: cached aggregated resources do not contain CSS/JS resources in the right order
-
#315885: Examples on IE7: Orbeon logo does not have enough space
-
#315883: Date picker on IE6: JavaScript error when typing a date like "March 1, 2011"
-
#315880: RFE: fr:currency: should not be susceptible to limitations of number precision imposed by the platform
-
#315879: xf:submission/@f:url-norewrite is not supported with replace="instance"
-
#315878: Allow fr:error-summary to set focus on the fr:autocomplete
-
#315877: Typing ]]> in a field causes a JavaScript error
-
#315876: Regression: FB: Schema upload no longer works
-
#315875: RFE: Support fr:autocomplete in Form Builder
-
#315874: fr:date-picker: click on text to the right of the image leads to JavaScript error
-
#315873: Portlet support: FR: Summary: going to 2nd page of data, clicking on entries takes user outside of portal
-
#315870: fr:button: if a readonly group, when becomes non-relevant, and relevant again, button shows readonly
-
#315872: xforms:input bound to xs:date: JavaScript error: missing jsDateToformatDisplayDate
-
#315871: Request Dispatcher: rewrites URI, incorrectly adding context to URI starting with /
-
#315557: XPath analysis: Checkbox with both itemset and value changing ends up in incorrect state
-
#315868: fr:button: CSS: new rule for Liferay prevents users from setting their own background image
-
#315858: XPath analysis: group validity not updated
-
#315522: RFE: Implement static XPath analysis to reduce number of XPath evaluations
-
#315408: RFE: XPath analysis must support model variables
-
#315863: FR: PDF: PDF button on detail page triggers popup blocker
-
#315850: Conflict between XForms 1.0/1.1 and XPath 2.0 versions of seconds-from-dateTime()
-
#315860: Separate deployment: user resources include app version number with versioned resources
-
#315859: RFE: Allow customization of the error panel width
-
#315857: fr:button: regression: readonly button becoming non-readonly on full update
-
#315856: Unit tests: error in saxon:parse() when running tests
-
#315855: fr:data: JavaScript exception: DATE_PICKER_TWO_MONTHS_PROPERTY is not defined
-
#315396: RFE: Make Form Runner work within portlets
-
#315818: Portlet support: FR: some CSS resources do not go through URL rewriter
-
#315831: Portlet support: FR: CSS: Liferay pages list appears garbled
-
#315817: Portlet support: FR: CSS loads late in the page, causing hidden elements to show for a while
-
#314490: RFE: Automatic aggregation of JS and CSS resources for XBL
-
#315853: RFE: fr:tabview: offer a configuration property to get the old behavior where the context wasn't changed by fr:tab
-
#315612: JavaScript error when new RTE in repeat is added and its value is set in the same request
-
#315848: NPE with submit within repeat within tabs
-
#315846: Dialog inside full update section not reinitialized
-
#315843: Upload: progress bar stays visible after upload is complete if the upload field is cleared with setvalue
-
#315837: RTE inside non-relevant group: when group becomes relevant, the RTE is still non-relevant
-
#315838: Portlet support: FR: PDF button on summary page causes error with PDF template
-
#315835: Portlet support: resource URLs don't load when versioned resources are enabled
-
#315820: Portlet support: FR: PDF button on summary page doesn't work
-
#315836: XForms sandbox: submit button shows lower than upload control
-
#315832: XForms Sandbox: upload button does not become enabled after a file is uploaded
-
#315815: Portlet support: upload control doesn't work
-
#315825: Databound select1 component not working anymore
-
#315535: XPath analysis: xxf:serialize() support: detect changes to nested elements
-
#315525: XPath analysis: bug with xf:output pointing to complex content
-
#315808: RTE: Server sends blank value, but RTE doesn't clear
-
#315821: Regression: invalid elements containing other elements no longer become invalid with unmet constraint
-
#315822: RFE: Datatable: Support fr-goto-page event with internal paging
-
#315814: Portlet support: FR: New button causes error
-
#315819: RFE: Support for am/pm instead of a.m./p.m. in xs:dataTime and xs:time inputs
-
#315813: Form Builder: shows a warning saying IE6 is being used when using IE9
-
#315812: Itemset evaluation using xxf:itemset() can impact further variables
-
#315811: oxf.xforms.order property is not documented
-
#315809: Regression: DMV-14 form: insert new vehicle -> leased checkbox is missing
-
#315664: FB: PERF: Insert of control causes 7 refreshes in sequence
-
#315803: Allow parameters of ORBEON.xforms.Document.getValue() and setValue() to be an element in addition to an id
-
#315801: Regression: Form Builder toolbox icons don't change to/from readonly appearance anymore
-
#315798: Regression: fr:tabview has some non-clickable tabs
-
#315727: PERF: Degradation of performance over time when a lot of state is stored into eXist
-
#315398: Retry mechanism is erratic with pseudo-Ajax submissions
-
#315639: RTE: values are not sent to the server when the RTE looses the focus
-
#315778: FR: RFE: workflow-send must support navigation to error page
-
#315763: PERF: New XForms state store using Ehcache
-
#315766: RFE: add ids on the following components to make automated testing easier: * fr:button * fr:dialog-select * fr:spell-checker * fr:tabview * fr:dialog-editor
-
#315666: RFE: Re-implement DMV-14 example using Form Runner
-
#315762: FR: RFE: Sample Form Runner data must be available out of the box
-
#315761: Upload: JavaScript error when clicking on "cancel"
-
#315760: Upload: for longer uploads, client is sending too many progress update requests
-
#315756: Upload: FB: new form, test form, click anywhere -> JS exception this.yuiProgressBar is null
-
#315759: JavaScript error loading XForms Controls example: YAHOO is not defined
-
#315755: Upload: with Chrome, in FR Bookshelf, first image upload gets "stuck"
-
#315728: Regression: "Cannot update MIP information on non-NodeWrapper NodeInfo" when going to summary page of old DMV-14 sample
-
#315754: WebLogic: java.lang.NoSuchMethodError: getDirectory
-
#314656: Allow any other action to run with a two-pass submission where the client does the POST in an iframe (file upload)
-
#315685: RFE: Support upload concurrently with other XForms actions
-
#315752: Date picker in scrollable area: is not anchored to the field, but to the page
-
#315740: RFE: FR: Implement proxy portlet for Liferay
-
#315634: JAWS/508-compliance: On IE, when the dialog for an <xforms:message> or <xxforms:dialog> is closed, the content of the dialog is read again.
-
#315737: RFE: Upload: support for cancelling uploads
-
#315735: Regression: separate deployment: replace all leading to 404 with relative path
-
#315732: Upload field on IE: JavaScript error on file selection
-
#315003: FR: RFE: Support eXist 1.4 Lucene-based free-text search
-
#315730: RFE: Upgrade to eXist 1.4
-
#315733: Incorrect MIPs when more than two binds point to the same node
-
#315705: New upload: JavaScript exception
-
#315725: fr:spell-checker: update corrections as users makes them
-
#315706: XPath analysis: switch FR language in controls/new doesn't work
-
#315718: Setting focus to fr:tabview/fr:datatable/xf:input doesn't switch to the correct tab
-
#315711: xf:select1: upon initial page view an incorrect item can be selected if the value and/or items contain spaces
-
#315709: XPath analysis: use of normalize-space() without argument does not introduce dependency on context
-
#315708: fr:dialog-select: error entry in error summary doesn't focus on fr:dialog-select control
-
#315692: XPath analysis: invalid control becomes valid again
-
#315622: XPath analysis: when enabled, Form Builder says section title is missing
-
#315704: xf:select/select1 control with internal appearance must reject xf:setfocus action
-
#315696: RFE: Upload to start upload as soon as the file selected, queue uploads, and allow Ajax requests in parallel to uploads
-
#315695: Alert dialog: the "x" in the title bar allows users to bypass making a choice
-
#315694: WebLogic: java.lang.NoSuchMethodError with Apache Common Lang
-
#315690: FR: New DMV-14 form: error summary out of sync with repeated items
-
#315005: JBoss 5/6: ClassCastException with Xalan's TransformerFactoryImpl
-
#315446: Characters lost and focus lost when entering first name in DMV 14 example
-
#315687: SQL address book example: code still using old ContentHandler API
-
#315684: Vulgarity in client side JavaScript
-
#315681: reCAPATCHA: if the first response is incorrect, subsequent tries always fail
-
#315679: Incoming Ajax requests must enforce association with session
-
#315680: RFE: fr:tabview: when the focus is set on a control inside a tabview, switch appropriate tab
-
#315678: XForms filter: if app session is invalidated, prevent further requests on page
-
#315676: Do not set focus on xf:output
-
#315675: FB: When app names are restricted, canceling initial metadata dialog sets blank form name
-
#315673: xf:output with text/html mediatype must not keep foreign attributes
-
#315671: FR: Section does not expand with Expand All button if it was closed individually
-
#315672: FR: Review button does not expand sections if there is an error in the form
-
#315543: Regression: Autocomplete in XForms Controls example is truncated
-
#315668: Disable loading of external entities in XML parsing by default
-
#315667: Over-aggressive page caching permitted with IE 7
-
#314945: RFE: Autocomplete: support readonly mode
-
#315661: Read-only control becoming relevant a second time does not appear as read-only
-
#315660: FB: RFE: Upon saving, expand sections when the form contains errors
-
#306918: RFE: Must be able to do submission replace="all" during initialization (xforms-ready/xforms-model-construct-done)
-
#315656: java.net.SocketException on replace instance and replace all leading to inexistent page
-
#315658: Separate deployment: xforms:load upon initialization in replace="all" page prepends servlet context twice
-
#315657: JavaScript error on browser back with Firefox 4
-
#315655: fr:autocomplete: initial value incorrectly set if one of the value is empty
-
#315644: FB: Deleting section does not delete associated resources
-
#315643: xforms:setfocus on an RTE has no effect
-
#315640: XBL: <xbl:content> does not conform to the XBL specification
-
#315635: FR: Summary page, link for existing forms opens /fr/orbeon/bookshelf/{$document-href}
-
#315633: JAWS/508-compliance: screen reader doesn't read message shown by xforms:message
-
#315632: FR summary page shows error about sorting
-
#315627: RFE: Tree: Way of specifying which branches are open when the itemset changes
-
#315626: RFE: fr:dialog-select and fr:spell-checker: add attribute to remove the "X" on the toolbar
-
#315624: RFE: fr:datatable: support for external sorting with internal paging
-
#313963: RFE: Implement captcha XBL control
-
#314353: RFE: instance inspector for XBL components
-
#315613: XBL: can't find variable declared in the same scope unless xxbl:scope is repeated
-
#315621: XPath analysis: incorrect in-scope variables within XBL when using xxf:sequence in different scope
-
#315619: fr:datatable: ability to switch to a given page by dispatching an event to the datatable
-
#315617: FB: RFE: Summary page must ask user confirmation before deleting forms
-
#314210: Horizontally scrollable datatables with 100% width and short rows are not correctly sized
-
#314679: RFE: add a fr:sortKey attribute to manually define sort keys when needed
-
#315615: fr:datatable: on Firefox 4, does not correctly resetting class on yui-dt-liner div after rows changed
-
#315614: fr:datatable: was relying on dynamic id to identify Ajax responses, which doesn't exist anymore
-
#315611: Form Builder: can't delete services, databases, and actions
-
#315610: xforms:message interprets the message as HTML instead of text
-
#315504: Regression: broken client-side handling of server error
-
#315605: Span mode: FR repeater does not show table headings
-
#315468: Regression: click on repeat iteration doesn't send Ajax request for several seconds
-
#315597: Upload: clear button doesn't work anymore
-
#315603: scala.MatchError when running with XPath analysis enabled
-
#315601: Span mode: JavaScript error when help is before label in minimal trigger
-
#315600: XForms Sandbox: download link causes server-side error
-
#315598: XPath analysis: required fields are not marked as invalid when the page is generated
-
#315599: FB: Itemset editor: enter key adds new item but focus is not set to new item
-
#315596: Full update: after full update init() is not automatically called on XBL components
-
#315595: Full update: need to reset some server values on full update
-
#315592: Full update: JavaScript error on IE when restoring the focus to a control which became readonly
-
#315589: fr:button: when inside a full update section, when becomes readonly, does not show as readonly
-
#315588: Datatable: when inside full update section, doesn't redraw when there is a full update
-
#315586: fr:button: if becomes non-readonly while non-relevant, when it becomes relevant, it still shows as readonly
-
#315584: delay-before-incremental-request has no effect
-
#315583: YUI 2.8.1 security vulnerability issue
-
#315582: JavaScript error if an element has the focus before a full update
-
#315581: Datatable: creates a new closure every 100 ms as long as the datatable is not visible
-
#315580: Select tree: checkboxes can't be selected
-
#315579: Select tree: on Firefox, first "+" or "-" doen't highlight on mouse over
-
#315571: Tabview: with nested tab view, clicking on 3rd tab of outer selects 3rd tab of inner
-
#315570: Fusion Charts XBL: cannot find swf files
-
#315563: XBL: NPE if missing id on automatically-included xbl:binding
-
#315562: Full update: span added around tr in markup sent over Ajax
-
#315547: Duplicate parameter event in xforms.js
-
#315560: FR: RFE: Option to accept XML posted to the "new" page
-
#315559: FB: Regression: Publish button should not be enabled if the form hasn't been saved
-
#315551: Datatable: JavaScript error when a datatable contains a table
-
#315549: FB: Validation dialog does not always read back values from bind
-
#315548: JavaScript error on IE when setting the value of an attribute expecting a number
-
#315544: HTML <br> in label outputs two <br> elements in the browser
-
#315542: Modal progress panel (spinner) going away too soon
-
#315257: NPE in OptimizedSubmission$1.close() for local response with no content
-
#315480: JAWS/508-compliance: fr:alert-dialog: content is not read by the screen reader
-
#315519: RFE: Upgrade from HttpClient 3.1 to HttpClient 4
-
#315509: xforms:submit not working inside fr:tabview
-
#315541: JavaScript error in controls example with switching to French in span mode
-
#315539: Our own versions of hasClass, addClass, removeClass can return wrong results when classes are changed by third-party code
-
#315436: Regression: changes to XBL and properties are not taken into account unless the XForms using the XBL changes
-
#315538: XPath analysis: custom MIPS appear to have no effect
-
#315537: RFE: Upgrade to YUI 2.8.1
-
#315523: XPath analysis: some expression with count() fail
-
#315534: RFE: YUI Calendar: support German ("de") localization
-
#315533: Portlet separate deployment: images referred from xforms.css do not load
-
#315532: RFE: XPath analysis: support xxf:serialize()
-
#315531: RFE: XPath analysis: support xxf:repeat-current()
-
#315530: YUI date picker not positioned properly for minimal appearance in repeat
-
#315528: ClassCastException thrown by Jetty when StringValue object is stored into the session
-
#315526: FB: With Chrome, toolbox shows horizontal scrollbar
-
#315241: XFormsContainingDocument are retained as long as the session didn't expire
-
#315483: RFE: Log URL and other details for HTTP connection errors such as timeouts
-
#315409: RFE: Support separate deployment with portlets
-
#315524: JavaScript error when using YAHOO.util.Assert
-
#315259: RFE: Improve retry mechanism to handle (a) connection down and (b) request not executed more than once
-
#315511: xforms:dispatch using value of ev:target instead of target
-
#315451: HTML controls within non-selected cases are not marked as disabled in the HTML generated by the server
-
#315506: FB: Schema types used by section templates cause runtime errors when template is used in page
-
#315505: FR: Regression: Summary page: Test and Delete buttons are not read-only when they should be
-
#315499: IE: JavaScript error when canceling navigation on submission replace="all"
-
#315498: Tree with multiple selection does not update instance in span mode
-
#315426: Spurious help icon appearing upon control becoming relevant
-
#315497: Regression: JavaScript error when using a modal trigger
-
#315496: FR: Error summary setfocus/href fails if the control in error is in a section template
-
#315495: Loading indicator is hidden after 2s even if the request lasts longer
-
#315425: Localized section template doesn't use language selected in Form Runner
-
#315494: RFE: fr:dialog-select: don't show 'x' in title bar as there is already a 'cancel' button
-
#315493: fr:spell-checker: button is not readonly when spell checker is bound to a readonly node
-
#315492: fr:button: readonly not updated when moved to another iteration
-
#315485: JAWS/508-compliance: fr:spell-checker doesn't have labels for form fields in dialogs
-
#315481: Regression: In FR summary page, when showing search options, the "search forms" button is disabled
-
#315484: ORBEON.xforms.Document.setValue() on xf:output changes value on the client but not on the server
-
#315477: JAWS/508-compliance: content of dialog that only has text is not read by screen reader
-
#315479: RFE: Support SO timeout in HttpClient
-
#315474: RFE: Support disabling HTTL stale checking
-
#315473: If a tooltip is visible at the time it is hidden, this leads to a JS error 5 seconds later
-
#315472: JS error in containerareaplugin.js when a Module is destroyed
-
#315460: xxf:invalid-binds() returns incorrect bind id with required-but-empty and constraint
-
#315469: Regression: second pass of replace="all" is not sent to server
-
#315439: XPath analysis: dialog select list empty
-
#315441: XPath analysis: button doesn't change state in dialog edit control
-
#315466: JAWS/508-compliance: content dialog not read when opened
-
#315463: Remove dependency on system-dependent paths in IntelliJ files
-
#315443: JAWS/508-compliance: screen reader doesn't read message shown by xforms:message
-
#315442: Regression: APPLICATION_RESOURCES_VERSION_PROPERTY property is no longer available in xforms.js
-
#315438: JAWS/508-compliance: Dialog select: selection area can steal focus on Firefox and content isn't read by screen reader
-
#315437: JAWS/508-compliance: Dialog select: add / remove button have no label, and hence are not read by screen reader
-
#315435: Temporary files containing "+" characters cause an exception with JBoss on OS X
-
#315434: Update to top-level repeat control nodeset causes exception if the nodeset refers to a preceding top-level variable
-
#315433: JAWS/508-compliance: box selector can steal the focus, and nothing is read when this happens
-
#315334: RFE: xxforms:get-request-path() function
-
#315421: Regression: some versioned resources fail when oxf:xforms-submission is used alongside oxf:xforms-to-xhtml
-
#315418: Exception when saving data to Oracle within JBoss
-
#315412: XPath analysis: ArrayIndexOutOfBoundsException when running certain expressions
-
#315404: A11y: Error summary title is not read by screen reader
-
#315401: XPath analysis: @bind incorrectly marks binding or value as not dependent
-
#315288: With doc cache disabled: XForms Controls: highlighted tab always returns to first tab
-
#315289: With doc cache disabled: autocomplete is broken
-
#315291: With doc cache disabled: some user events are ignored
-
#315220: Boolean input: 2 labels pointing to the input prevent screen reader from reading label
-
#315263: Regression: RTE doesn't initially appear readonly when needed
-
#315258: oxf:xforms-submission with custom actions causes failed assertion with -ea enabled because ids are missing
-
#315252: RFE: Implement XForms static state caching based on static state digest
-
#315251: RFE: Add 'alt' for the processing image shows by incremental trigger
-
#315244: Failed assertion using xforms:label/xforms:output or xforms:label/AVT within XBL
-
#313690: JavaScript exception when inserting iteration in repeat with RTE
-
#315242: Infinite loop with repeats when using WebLogic 10.3.0 on Linux
-
#315227: JavaScript error when using an xforms:output appearance="xxforms:download"
-
#315226: Alert dialog: reference to non-existent alert-dialog.css from YUI
-
#315221: FR: time stored in MySQL is incorrect
-
#315211: RFE: Provide a message-format() extension XPath function similar to Java's
-
#315218: RTE: JS exception when readonly MIP changes
-
#315208: PERF: Store XForms namespace mappings in more compact way and use hash to index XPath expressions in cache
-
#315198: Non-relevant links and minimal triggers can get the focus
-
#315197: fr:button: IE: no margin anymore around button
-
#314491: Insert with xxforms:iterate, context, nodeset, and origin has no effect
-
#315183: Error summary: does not update class xforms-invalid-visited on the control on fr-visit-all and fr-unvisit-all
-
#315181: XForms translate not returning any result when typing
-
#315160: RFE: Modal trigger doing a load or submission with xxforms:show-progress="false" should not show spinner while loading URL
-
#315159: Control inside group incorrectly becomes valid when the class on the group changes
-
#315153: IE 6/7: fr:button border is cut when in table with cellpadding="0"
-
#315140: exf:sort() can cause "invalid slot for variable" error in Saxon
-
#315131: RFE: Support XML comments in the pipeline engine and XForms
-
#315137: Input bound to xs:dateTime control: setting node value does not populate the 2 text fields correctly
-
#315134: FR: Saving fails if the error summary is completely disabled
-
#315133: FR: message "Document saved successfully!" not shown anymore
-
#315130: Dialog editor: when the readonly MIP changes after the form is loaded, the button doesn't change
-
#315082: Refresh is needed after recalculate, otherwise control value is not updated (while it should)
-
#315124: Autocomplete: show full list button with arrow always next to the input field
-
#315128: When a trigger xxforms:modal="trigger" does an xforms:load, the spinner is hidden while the new page is loaded
-
#315127: Regression: with new full input/label layout, boolean input label update fails in new repeat iterations or when becoming relevant
-
#315126: RFE: Improve positioning of the date picker so if it can't be shown below the control, it we try to show it above the control
-
#315125: Dialog: title showing empty (instead of not being displayed)
-
#315120: Type change for controls other than xforms:input does not set a class on the control
-
#315118: RFE: dialog editor: only produce icon, so it can be attached to an existing text area
-
#315117: Dialog: header is collapsed when the label is empty
-
#315116: PERF: xforms:refresh should not force refresh if the refresh flag is not set
-
#315113: RFE: Attribute on xforms:submission to prevent recalculation
-
#315112: PERF: Do not check and run validation at all if validate="false" on xforms:submission
-
#315107: fr:select1-button: on IE, when the itemset changes, the drop-down becomes empty
-
#315102: FB: When XML Schema with targetNamespace is used xf:bind/@type is not prefixed and causes an error
-
#308967: RFE: Implement XForms 1.1 current() function
-
#315091: When readonly input control becomes enabled, it looses its disabled attribute
-
#315090: FR: RFE: Component to select a US state
-
#315085: Full xf:select bound to xs:boolean sends non-encrypted "false" when deselected, causes exception on server-side
-
#315084: RFE: Improve unit tests to show the time taken by the current test and all the tests ran so far
-
#315081: Error "Repeat index was not set for repeat id"
-
#315072: Input of type boolean are disabled when recreated
-
#315074: oxf:xforms-to-xhtml incorrectly uses URLs of replaced instances as dependencies
-
#315071: FR: Summary: control with @ref within section with @bind doesn't show value in table or search
-
#315060: request-retries: does not honor the value specified
-
#315055: request-retries: some errors don't trigger the request to be resent to the server, thus making oxf.xforms.request-retries ineffective
-
#315049: NPE in getWriter()
-
#315018: Long-running background file upload causes exception if user interacts with the page in the meanwhile
-
#315017: RFE: XForms cache/store must not serialize state at every request
-
#315047: RFE: xforms:recalculate to support forcing re-evaluation of initial values
-
#315041: Error summary: error stays after iteration with error is deleted
-
#315044: fr:button: copy class attribute in output if present on fr:button element
-
#315040: RFE: New dialog-editor component
-
#315039: fr:button: even it is not bound to a node, if the context node is readonly, the button is disabled
-
#315033: Tabbing doesn't go over disabled fields
-
#315030: Dialog: when in repeat, delete iteration, recreate, open dialog leads to gray screen
-
#315029: Spell checker: buttons show outside of dialog with the font is smaller
-
#308757: Dialog title can't be changed after the page is loaded (i18n issue)
-
#315016: Dialog in repeat template is missing its title
-
#315013: FR: Go button throwing NPE
-
#314755: Autocomplete: does not take a value from an instance
-
#315010: Spell checker: when done spell checking, the Done button is incorrectly left aligned
|
|